-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add missing field in command palette type #111
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for nuxthq-ui canceled.
|
Since this is a "dynamic field", should we really add it in those types?
|
I think there is more sense to force the lib users to override types if they are indeed overriding props. In my case, I'm not overriding anything and using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather put [key: string]: any
instead of hard-coding label
19a38d6
to
d98ac52
Compare
just updated it |
No description provided.